Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exim: add SPF support (+ init libspf2 at 1.2.10) #67263

Merged
merged 2 commits into from Aug 24, 2019
Merged

exim: add SPF support (+ init libspf2 at 1.2.10) #67263

merged 2 commits into from Aug 24, 2019

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Aug 22, 2019

Motivation for this change

This PR adds SPF support to the exim package and inits libspf2 at 1.2.10.

I'm not sure whether we should enable SPF by default, as it's quite common.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @4z3 (exim package maintainer)

@ofborg build libspf2
@ofborg build exim

@dasJ
Copy link
Member

dasJ commented Aug 22, 2019

I think it's a good idea to enable it by default as it's (as you said) really common and exim options which aren't enabled by default tend to break over updates as they are not automatically tested.

@4z3
Copy link
Contributor

4z3 commented Aug 22, 2019

+1 for enabling it by default

@pacien
Copy link
Contributor Author

pacien commented Aug 22, 2019

Amended to enable SPF support by default.

@risicle
Copy link
Contributor

risicle commented Aug 23, 2019

libspf2 builds successfully macos 10.13.

@disassembler
Copy link
Member

@GrahamcOfBorg build libspf2 exim

@disassembler disassembler merged commit 7cec032 into NixOS:master Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4z3 4z3 4z3 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pacien @dasJ @4z3 @risicle @disassembler