-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pivx wallet pivx: 3.2.0 -> 3.4.0 #67412
Conversation
This is marked as broken on master, please see 2542928. If you update supports this, please rebase and drop the broken flag. |
Interesting. I was able to build and run the application from this patched derivation. I will look into this soon. EDIT 1: I haven't rebased to upstream before submitting this PR, and indeed I'm running with openssl 1.0.2. |
I don't trust upstream who haven't updated from an openssl version that has been EOL for years and includes a number of security issues. That is quite an alarming sign of negligence on their part. |
@globin has a good point, that the trust in the product is questionable in case they are using EOL libraries, even more if it's a cryptocurrency, however I agree with @wucke13 that we should leave it up to the maintainer to fix any problems with the package and only when we fail to get in touch with the maintainer we should mark the package as broken. |
Thank you for the fast responses! Indeed, it depends on PS: I |
Hard to say how they are using it, but I would maybe open a github issue with them with the request to update, at least in the future? One last rebuild before merging. @GrahamcOfBorg build altcoints.pivx |
@mmahut You had a typo, one After doing a quick research, I have to oppose to @globin 's claim of
According to https://mta.openssl.org/pipermail/openssl-announce/2019-May/000151.html openssl-1.0.2 is still maintained, with having its most recent release just four months back in the past. To me this looks like a 'not so well though-through' basis to convince any pivx maintainer of this being an actual issue. |
@GrahamcOfBorg build altcoins.pivx @wucke13 but they claim 1.0.2 is not supported, only 1.0.1 is. |
Where do they claim that? |
Looks like they have stopped using that check yesteday as per PIVX-Project/PIVX#991. Please rebase as there is a conflict, given the file has been moved from altcoins to blockchains. |
Ok. The package is still not evaluating with |
@GrahamcOfBorg build pivx |
b150e06
to
7ab70af
Compare
7ab70af
to
73c0c53
Compare
Furthermore, this fixes 2542928
Added `test_pivx` as test ran by nixpkgs
73c0c53
to
832344a
Compare
@mmahut |
tested with nix-review, started pivx-qt and clicked around a little bit, everything looked fine |
Thanks to @Lassulus for fixing this typo! Co-Authored-By: Lassulus <github@lassul.us>
@GrahamcOfBorg eval |
@Lassulus Thank you! Can we backport this to |
Sure, can you open a backport PR? |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @