Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solc: 0.5.10 -> 0.5.11 #67360

Merged
merged 2 commits into from Aug 24, 2019
Merged

solc: 0.5.10 -> 0.5.11 #67360

merged 2 commits into from Aug 24, 2019

Conversation

livnev
Copy link
Contributor

@livnev livnev commented Aug 23, 2019 •
edited

Motivation for this change

This bumps the version to 0.5.11 and enables building with cvc4 support. As was discovered here: ethereum/solidity#7297, cvc4 support is needed for the tests to pass.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @asymmetric

@livnev
solc: 0.5.10 -> 0.5.11
fbf323b
@livnev
solc: build with cvc4 support
917ce8e 
n.b. that cvc4 support is required for the tests to pass
@livnev livnev changed the title solc 0.5.11 solc: 0.5.10 -> 0.5.11 Aug 23, 2019
@livnev livnev mentioned this pull request Aug 23, 2019
Closed
@ofborg ofborg bot requested a review from akru August 23, 2019 17:39
@risicle
Copy link
Contributor

risicle commented Aug 23, 2019 •
edited

nix-review checks out on macos 10.13, binaries appear to work.

@disassembler
Copy link
Member

@GrahamcOfBorg build solc

@disassembler disassembler merged commit 1718824 into NixOS:master Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akru akru Awaiting requested review from akru

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@livnev @risicle @disassembler