Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.nltk: 3.2.5 -> 3.4.5 (security fix - backport to release-19.03) #67307

Merged
merged 4 commits into from Aug 23, 2019
Merged

pythonPackages.nltk: 3.2.5 -> 3.4.5 (security fix - backport to release-19.03) #67307

merged 4 commits into from Aug 23, 2019

Conversation

lsix
Copy link
Member

@lsix lsix commented Aug 22, 2019

Motivation for this change

Port #67278 to release-19.93

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @dtzWill

couchemar and others added 4 commits August 23, 2019 00:23
@couchemar @lsix
pythonPackages.nltk: 3.2.5 -> 3.4 (NixOS#59204)
aa5608f 
Add optional dependency "singledispatch" for python 2.7.
Remove "disabled" attribute from derivation.

(cherry picked from commit 2e9e631)
@dtzWill @lsix
python3Packages.nltk: 3.4 -> 3.4.3
e60a0dd 
(cherry picked from commit da8d885)
@r-ryantm @lsix
python37Packages.nltk: 3.4.3 -> 3.4.4
f4d1cc4 
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/python3.7-nltk/versions

(cherry picked from commit 3d121eb)
@dtzWill @lsix
python3Packages.nltk: 3.4.4 -> 3.4.5 (security)
aba9134 
https://www.nltk.org/news.html
(cherry picked from commit 6d20635)
@lsix lsix requested a review from dtzWill August 22, 2019 22:41
@lsix lsix requested a review from FRidh as a code owner August 22, 2019 22:41
@ofborg ofborg bot requested a review from lheckemann August 22, 2019 22:54
@lheckemann lheckemann merged commit e6ad5e7 into NixOS:release-19.03 Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill Awaiting requested review from dtzWill

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@lheckemann lheckemann Awaiting requested review from lheckemann

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lsix @lheckemann @couchemar @dtzWill @r-ryantm