Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-sam-cli: update requests dependency to 2.22.0 #67267

Merged
merged 1 commit into from Aug 22, 2019
Merged

aws-sam-cli: update requests dependency to 2.22.0 #67267

merged 1 commit into from Aug 22, 2019

Conversation

scoates
Copy link
Contributor

@scoates scoates commented Aug 22, 2019 •
edited

Motivation for this change

pythonPackages.requests was updated to v2.22.0 on July 21.

aws-sam-cli is hard-coded to set the requests version to 2.21.0, so aws-sam-cli currently fails to build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @andreabedini @dhl

@grahamc
Copy link
Member

grahamc commented Aug 22, 2019

@GrahamcOfBorg build aws-sam-cli

jonringer
jonringer approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable seems to work
leaf package

[2 built, 15 copied (4.4 MiB), 1.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/67267
1 package were build:
aws-sam-cli

@grahamc grahamc merged commit 7305796 into NixOS:master Aug 22, 2019
@scoates scoates deleted the update-aws-sam-cli branch August 22, 2019 18:11
@scoates scoates mentioned this pull request Aug 22, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@scoates @grahamc @jonringer @Janik-Haag