Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gevent-websocket: enable python3 #67266

Merged
merged 1 commit into from Aug 24, 2019
Merged

gevent-websocket: enable python3 #67266

merged 1 commit into from Aug 24, 2019

Conversation

praetorg
Copy link
Contributor

Motivation for this change

Enable building for python3

Things done

Extend build inputs to include gunicorn and enable building for python3

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

None specified.

@praetorg
Update gevent-websocket to enable python3
d44d484 
Extend build inputs to include gunicorn and enable building for python3
@praetorg praetorg requested a review from FRidh as a code owner August 22, 2019 16:36
@praetorg praetorg changed the title gevent-websocket enable python3 gevent-websocket: enable python3 Aug 22, 2019
@disassembler
Copy link
Member

@GrahamcOfBorg build python3Packages.gevent-websocket

@disassembler disassembler merged commit 578a619 into NixOS:master Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@praetorg @disassembler @Janik-Haag