Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deluge: 1.3.15 -> 2.0.3 [WIP] #67264

Closed
wants to merge 3 commits into from
Closed

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Upgrade from 1.3.15 to 2.0.3. At the same time we move to py3 and gtk3.

I know that @FRidh is hesitant to add new packages but the problem here is that we don't carry pytest-twisted which is needed for the tests to run.

Also a libtorrent-rasterbar update to go along with this.

The toolbar icons don't look great here, but that may be due to my theme/settings.

WIP because the libtorrent change breaks qbittorrent.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Anton-Latukha @Phreedom @domenkozar @ebzzry

Copy link
Contributor

@Anton-Latukha Anton-Latukha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I observed the libtorrentRasterbar changes.

@infinisil
Copy link
Member

infinisil commented Aug 31, 2019

There's already #64542, ping @dtzWill

propagatedBuildInputs = with python3Packages; [
dbus-python geoip2 pillow rencode setproctitle six
twisted Mako chardet pyxdg pyopenssl service-identity
(libtorrentRasterbar.override { inherit (python3Packages) python; }).python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this done. libtorrentRasterbar exists in python-packages.nix and should be build for your interpreter already.

@peterhoeg
Copy link
Member Author

Closing in favour of #64542.

@peterhoeg peterhoeg closed this Sep 4, 2019
@peterhoeg peterhoeg deleted the u/deluge branch September 4, 2019 08:11
@peterhoeg peterhoeg restored the u/deluge branch September 5, 2019 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants