Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackage.pyown: fix builds #67249

Merged
merged 2 commits into from Aug 24, 2019
Merged

pythonPackage.pyown: fix builds #67249

merged 2 commits into from Aug 24, 2019

Conversation

lsix
Copy link
Member

@lsix lsix commented Aug 22, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Version 2.10 relaxed the requirement for geojson from
`geojson>=2.3.0,<2.4` to `geojson>=2.3.0,<3`. Remove the postPatch hook
that adjusted this requirement when it broke in nixpkgs.
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
leaf package

[2 built, 2 copied (3.6 MiB), 3.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/67249
1 package were build:
python37Packages.pyowm

@risicle
Copy link
Contributor

risicle commented Aug 23, 2019

nix-review happy on macos 10.13, package imports ok.

@mmahut
Copy link
Member

mmahut commented Aug 24, 2019

@GrahamcOfBorg build python37Packages.pyowm

@mmahut mmahut merged commit 19081d4 into NixOS:master Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants