Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ckb-next: use qt5's mkDerivation #67417

Merged
merged 1 commit into from Aug 25, 2019
Merged

ckb-next: use qt5's mkDerivation #67417

merged 1 commit into from Aug 25, 2019

Conversation

alkeryn
Copy link
Contributor

@alkeryn alkeryn commented Aug 25, 2019 •
edited

Motivation for this change

The usual qt missing the xcb plugin error message

Things done

replaced stdenv.mkDerivation by mkDerivation

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@teto
Copy link
Member

teto commented Aug 25, 2019

tested with nix-review.

@teto teto merged commit af9f401 into NixOS:master Aug 25, 2019
@alkeryn alkeryn deleted the ckb-next branch August 26, 2019 12:14
@alkeryn alkeryn mentioned this pull request Aug 27, 2019
Closed
@kierdavis
Copy link
Contributor

TIL this is a thing 😮

@alkeryn
Copy link
Contributor Author

alkeryn commented Aug 30, 2019

TIL this is a thing

Yeah it is pretty new and isn't even in the official manual, but basically you need to use that for qt apps now or they might not work and have "xcb pluging missing" errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alkeryn @teto @kierdavis