Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.dogtail: fix sniff #67352

Merged
merged 1 commit into from Aug 25, 2019
Merged

pythonPackages.dogtail: fix sniff #67352

merged 1 commit into from Aug 25, 2019

Conversation

symphorien
Copy link
Member

Motivation for this change

fix sniff.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip" (no diff found!)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jtojnar
I suppose there is a better way than explicitly populating GI_TYPELIB_PATH, but I have not found it.

@symphorien symphorien requested a review from FRidh as a code owner August 23, 2019 14:14
@jtojnar
Copy link
Contributor

jtojnar commented Aug 23, 2019

I would say the problem is caused by this issue #56943

@symphorien
Copy link
Member Author

Well spotted, thanks.

@ofborg ofborg bot requested a review from jtojnar August 25, 2019 11:54
@worldofpeace worldofpeace merged commit 16c5acf into NixOS:master Aug 25, 2019
@symphorien symphorien deleted the dogtail branch March 21, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@symphorien @jtojnar @worldofpeace