Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teamviewer: fix issue #61712 #67343

Merged
merged 1 commit into from Aug 24, 2019
Merged

teamviewer: fix issue #61712 #67343

merged 1 commit into from Aug 24, 2019

Conversation

jraygauthier
Copy link
Member

@jraygauthier jraygauthier commented Aug 23, 2019 •
edited

Motivation for this change

As specified in #61712.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested connecting to and from this teamviewer (xfce). Everything now works fine.

Notify maintainers

cc @jagajaga @dasuxullebt

@jraygauthier
Copy link
Member Author

jraygauthier commented Aug 23, 2019 •
edited

This would be a must for upcoming nixos release 19.09 and for current 19.03 if still possible.

@Ma27 Ma27 self-requested a review August 24, 2019 00:57
@Ma27
Copy link
Member

Ma27 commented Aug 24, 2019

This would be a must for upcoming nixos release 19.09 and for current 19.03 if still possible.

I'm pretty sure that it'll land in 19.09 as branch-off for that release is at 7th september. Not sure if we'll backport this to 19.03 as well, I'll have a detailed look at this pakcage tomorrow.

@mmahut mmahut merged commit 82291d6 into NixOS:master Aug 24, 2019
@jraygauthier
Copy link
Member Author

@mmahut: Thanks for the quick merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jraygauthier @Ma27 @mmahut