Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/vte: ensure bash vte snippet appears first #67351

Merged
merged 1 commit into from Aug 24, 2019

Conversation

worldofpeace
Copy link
Contributor

Fixes #67312

Motivation for this change

See #67312

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jtojnar
Copy link
Contributor

jtojnar commented Aug 23, 2019

What if we used environment.etc."profile.d/vte.sh" as originally proposed? Would not that behave as expected?

@worldofpeace
Copy link
Contributor Author

I could, but there's not much of a difference either way?

@jtojnar
Copy link
Contributor

jtojnar commented Aug 23, 2019

Why did we refuse it in the first place?

@worldofpeace
Copy link
Contributor Author

I think I choose not too simply because there was no precedent for it in nixpkgs.
And the implementation matches that the options are specific to each shell.

@jtojnar
Copy link
Contributor

jtojnar commented Aug 23, 2019

In the initial post, it was proposed without much explanation why it is better #40878 (comment)

@jtojnar
Copy link
Contributor

jtojnar commented Aug 23, 2019

Won’t we need the same for zsh?

@worldofpeace
Copy link
Contributor Author

In the initial post, it was proposed without much explanation why it is better #40878 (comment)

Right, think it's because it's "global" but these very options operate on files in /etc

Won’t we need the same for zsh?

I'd check, but it looks like that module orders things differently.

@worldofpeace
Copy link
Contributor Author

I'd check, but it looks like that module orders things differently.

Checked, setting things in promptInit for zsh didn't appear to be overridden.

@worldofpeace worldofpeace merged commit d9cf3ee into NixOS:master Aug 24, 2019
@worldofpeace worldofpeace deleted the fix-vte-prompt-command branch August 24, 2019 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using PROMP_COMMAND in programs.bash.promptInit stopped working in vte terminals
3 participants