nixos/modules/services/x11/hardware/: add cmt module #67241
Conversation
|
I've updated the maintainer-list.nix file to include me but not sure how to start the tests again. |
kcalvinalvin
force-pushed
the
cmt
branch
2 times, most recently
from
e00df94
to
c2b53cf
Compare
|
Can you fix all the trailing whitespace please?
Also, I think you might have misunderstood how licenses.nix. The license
in this case appears to just be bsd3, so you can just use that unless
there's something extra specific to ChromiumOS I'm missing?
Finally, commit messages should be in the form described in the Nixpkgs
manual.
|
|
Fixed trailing whitespace and commit message. I'm still not sure if this is the right commit message to have since there are no examples for making new modules so please let me know if it's not following the formatting. For ChromiumOS there needs to be this text included. I wasn't quite sure how to go about it so I just made a repo for it but it seems like github just added BSD3 to the repo. If there is a better way of going about it, I'll certainly do so. |
kcalvinalvin
changed the title
|
Fixed trailing whitespace and commit message. I'm still not sure if
this is the right commit message to have since there are no examples
for making new modules so please let me know if it's not following the
formatting.
Since you're adding new packages and new modules in the same commit, I
think it would be fine to just phrase the commit message as if you were
adding the package.
For ChromiumOS there needs to be
[this](https://github.com/kcalvinalvin/ChromiumOS_License/blob/master/LICENSE)
text included.
I wasn't quite sure how to go about it so I just made a repo for it
but it seems like github just added BSD3 to the repo. If there is a
better way of going about it, I'll certainly do so.
This is just the standard 3-Clause BSD license, with appropriate
substitutions made for the names of the project and authors. So we can
just use licenses.bsd3. Otherwise we'd end up with an entry in
licenses.nix for every project and it would be tens of thousands of
lines long.
|
|
Changed commit message and removed/replaced chromeos license to bsd3 |
|
@GrahamcOfBorg build libgestures |
|
Is there anything else that I need to do? |
|
Would be nice if you could clean up the commits. Initial commit for adding to the maintainer list, then one commit for each package, then a commit for the NixOS module |
Adds custom touchpad drivers for Chromebooks.
|
Cleaned up the commits as requested |
|
Thanks, LGTM :) |
nixos/modules/services/x11/hardware/: add cmt module (cherry picked from commit 916603c)
Motivation for this change
To add support for cmt (Chrome Multitouch), custom built drivers for Chromebooks.
Known issues: Can't control such things as acceleration through the desktop environment's GUI. Places an empty 50 or 60 .conf file in the /etc/X11/xorg.conf.d/
Things done
Fixes applied for the changes requested for #66195 (git commit cleanup and various changes)
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @infinisil