Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dune: 1.11.1 -> 1.11.2 #67313

Merged
merged 2 commits into from
Aug 23, 2019
Merged

dune: 1.11.1 -> 1.11.2 #67313

merged 2 commits into from
Aug 23, 2019
+3 −3

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Aug 23, 2019

Motivation for this change

Changelog: https://github.com/ocaml/dune/releases/tag/1.11.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

marsam added 2 commits August 22, 2019 19:10
@marsam
dune: 1.11.1 -> 1.11.3

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
53e6fd9
@marsam
dune: add marsam as maintainer

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
b814375
@ofborg ofborg bot requested a review from vbgl August 23, 2019 00:29
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Aug 23, 2019
@vbgl
Copy link
Contributor

vbgl commented Aug 23, 2019

@GrahamcOfBorg build flow fstar trv eff stog

@vbgl vbgl merged commit f7c9670 into NixOS:master Aug 23, 2019
@marsam marsam deleted the update-dune branch August 23, 2019 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl

Assignees
No one assigned
Labels
6.topic: ocaml 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @vbgl