Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ripasso-cursive: init unstable at 2019-08-27 #67402

Merged
merged 2 commits into from Aug 28, 2019
Merged

ripasso-cursive: init unstable at 2019-08-27 #67402

merged 2 commits into from Aug 28, 2019

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Aug 24, 2019 •
edited

Motivation for this change

Ripasso is a simple password manager written in Rust, compatible with password-store repos.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @adisbladis

etu
etu requested changes Aug 24, 2019
View reviewed changes
Copy link
Contributor

@etu etu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes noted inline

pkgs/tools/security/ripasso/cursive.nix Outdated Show resolved Hide resolved
pkgs/tools/security/ripasso/cursive.nix Outdated Show resolved Hide resolved
pkgs/tools/security/ripasso/cursive.nix Outdated Show resolved Hide resolved
pkgs/tools/security/ripasso/cursive.nix Outdated Show resolved Hide resolved
pkgs/tools/security/ripasso/cursive.nix Outdated Show resolved Hide resolved
pkgs/tools/security/ripasso/cursive.nix Outdated Show resolved Hide resolved
@etu
Copy link
Contributor

etu commented Aug 24, 2019

Seems to have unit tests failing as well:

running 2 tests
test pass::test::get_password_dir ... ok
test pass::test::get_password_dir_no_env ... FAILED

failures:

---- pass::test::get_password_dir_no_env stdout ----
thread 'pass::test::get_password_dir_no_env' panicked at 'called `Result::unwrap_err()` on an `Ok` value: "/build/.tmplCgR7Z"', src/libcore/result.rs:999:5
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.


failures:
    pass::test::get_password_dir_no_env

test result: FAILED. 1 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out

error: test failed, to rerun pass '--lib'

@stigtsp stigtsp force-pushed the package/ripasso-cursive-unstable branch from 6b0b309 to fe0b09b Compare August 24, 2019 17:55
@stigtsp
Copy link
Member Author

stigtsp commented Aug 24, 2019

Seems to have unit tests failing as well:
cc: @alexanderkjall

@etu
Copy link
Contributor

etu commented Aug 24, 2019

@GrahamcOfBorg build ripasso-cursive

@stigtsp stigtsp force-pushed the package/ripasso-cursive-unstable branch from fe0b09b to ee9724c Compare August 28, 2019 09:47
@stigtsp stigtsp changed the title ripasso-cursive: init unstable at 2019-08-24 ripasso-cursive: init unstable at 2019-08-27 Aug 28, 2019
@stigtsp stigtsp force-pushed the package/ripasso-cursive-unstable branch from ee9724c to 2d36aa6 Compare August 28, 2019 09:56
@adisbladis
Copy link
Member

@GrahamcOfBorg build ripasso-cursive

@adisbladis adisbladis merged commit eb0189c into NixOS:master Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu etu requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stigtsp @etu @adisbladis