Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.wsproto: 0.14.1 -> 0.15.0 #67303

Merged
merged 2 commits into from Aug 22, 2019
Merged

python3Packages.wsproto: 0.14.1 -> 0.15.0 #67303

merged 2 commits into from Aug 22, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 22, 2019 •
edited

Motivation for this change

closes #67124

keep python2 version building for the ~10 people that still use it :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers
https://github.com/NixOS/nixpkgs/pull/67303
5 package were build:
mitmproxy python37Packages.fastapi python37Packages.starlette python37Packages.uvicorn python37Packages.wsproto

@jonringer jonringer requested a review from FRidh as a code owner August 22, 2019 21:36
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python27Packages.wsproto python35Packages.wsproto python36Packages.wsproto python37Packages.wsproto

@lsix
Copy link
Member

lsix commented Aug 22, 2019

👍 Thanks for the PR.

@lsix lsix merged commit 1e24977 into NixOS:master Aug 22, 2019
@jonringer jonringer deleted the bump-wsproto branch August 22, 2019 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsix lsix lsix left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @lsix