Hey @adisbladis.

The manual desktop file is unneeded in the graphical iso now, as the nixos documentation ships its own desktop file

• nixpkgs/nixos/modules/misc/documentation.nix

  Line 58 in 9d9b98c

  desktopItem = pkgs.makeDesktopItem {

We might have to link it to the desktop from /run/current-system/sw/share/applications though.

Hijacked your PR a bit here @adisbladis. Hope you don't mind 😄

The only commit I'm concerned about here is 119579f.
I've seen some un-fun moments with nouveau in #nixos.

What is the status of this?

It's after 19.09 now so I guess we'll finish this for 20.03.

@ttuegel The only change that was originally from here was making libinput default for plasma5.

It's after 19.09 now so I guess we'll finish this for 20.03.

It all looks good to me, so if it's ready, let's merge! It will still be good to have in master for those of us who periodically have to generate our own ISOs. 😃

+1 on re-enabling nouveau 6948c3a#commitcomment-12369327

Though maybe we could add a new option in the boot menu to blacklist nouveau if there are fears of issues.

After having checked the kernel source, we don't need to add blacklisting for the nouveau driver as an option I think. In the off chance a platform is found that nomodeset is not enough, they can edit the command line themselves to do it.

nomodeset should be enough for most cases.

https://github.com/torvalds/linux/blob/a2953204b576ea3ba4afd07b917811d50fc49778/drivers/video/console/vgacon.c#L112-L124
https://github.com/torvalds/linux/blob/a2953204b576ea3ba4afd07b917811d50fc49778/drivers/gpu/drm/nouveau/nouveau_drm.c#L1256-L1263

It short circuits the driver initialization at pretty much the earliest moment possible.

@samueldr Sounds good. Thanks for checking with me.