Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

seafile-client: Use qt5's mkDerivation #67270

Merged
merged 1 commit into from Aug 23, 2019
Merged

seafile-client: Use qt5's mkDerivation #67270

merged 1 commit into from Aug 23, 2019

Conversation

greizgh
Copy link
Contributor

@greizgh greizgh commented Aug 22, 2019

Motivation for this change

Following #65399 this update seafile-client to use qt5's mkDerivation.

Launching seafile-applet from systemd user unit was not working, with these changes it's working again.
This is my first contribution to nixpkg, feel free to comment and suggest improvements.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
Copy link
Contributor

Can you link the tracking issue in the commit body @greizgh?

@greizgh
Copy link
Contributor Author

greizgh commented Aug 23, 2019

Can you link the tracking issue in the commit body @greizgh?

Sure thing! Done and formatted the wrapper args

@worldofpeace worldofpeace merged commit 3fffe5a into NixOS:master Aug 23, 2019
@worldofpeace
Copy link
Contributor

Thanks for fixing this @greizgh ✨

@greizgh greizgh mentioned this pull request Sep 14, 2019
Merged
10 tasks
@worldofpeace worldofpeace mentioned this pull request Feb 26, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@greizgh @worldofpeace @Janik-Haag