Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitea: 1.9.1 -> 1.9.2 #67269

Merged
merged 1 commit into from Aug 22, 2019
Merged

gitea: 1.9.1 -> 1.9.2 #67269

merged 1 commit into from Aug 22, 2019

Conversation

kolaente
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Ma27
Copy link
Member

Ma27 commented Aug 22, 2019

@GrahamcOfBorg test gitea

@kolaente
Copy link
Member Author

Changelog is here: https://blog.gitea.io/2019/08/gitea-1.9.2-is-released/

@Ma27
Copy link
Member

Ma27 commented Aug 22, 2019 •
edited

Hmm it seems as ofborg didn't actually run the tests... let's try again:
@GrahamcOfBorg test gitea

@Ma27
Copy link
Member

Ma27 commented Aug 22, 2019

After looking through the changelogs I guess that it's also a good idea to backport that.

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Aug 22, 2019
@etu
Copy link
Contributor

etu commented Aug 22, 2019

@GrahamcOfBorg build nixosTests.gitea

@kolaente
Copy link
Member Author

@Ma27 should I send a backport pr?

@etu
Copy link
Contributor

etu commented Aug 22, 2019

@Ma27 should I send a backport pr?

Please do :)

@kolaente kolaente mentioned this pull request Aug 22, 2019
Merged
10 tasks
@kolaente
Copy link
Member Author

@etu @Ma27 Backport is up: #67292

@etu etu merged commit 4adaa84 into NixOS:master Aug 22, 2019
@Ma27
Copy link
Member

Ma27 commented Aug 22, 2019

Ah forgot to give my approval, but also tested this, so another 👍 - just for the record %)

@kolaente kolaente deleted the update/gitea-1.9.2 branch August 22, 2019 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kolaente @Ma27 @etu