Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyfcm: init at 1.4.7 #67321

Merged
merged 3 commits into from Feb 9, 2020
Merged

pythonPackages.pyfcm: init at 1.4.7 #67321

merged 3 commits into from Feb 9, 2020

Conversation

ldelelis
Copy link
Member

@ldelelis ldelelis commented Aug 23, 2019 •
edited

Motivation for this change

I'm enjoying my experience as a developer with NixOS so far, and I want to make nixpkgs friendlier to other Python developers. Pyfcm is, along many other unpackaged libraries, a dependency to many projects I currently work at.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ldelelis ldelelis requested a review from FRidh as a code owner August 23, 2019 03:07
@ldelelis
Copy link
Member Author

ldelelis commented Sep 8, 2019

Anything missing here? Let me know if there's anything else I need to check please!

@FRidh FRidh merged commit d1508cb into NixOS:master Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut left review comments

@disassembler disassembler disassembler left review comments

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldelelis @mmahut @disassembler @jonringer @FRidh