Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teamviewer: 14.4.2269 -> 14.5.1691 #67244

Merged
merged 1 commit into from Aug 22, 2019
Merged

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Aug 22, 2019

Motivation for this change

https://community.teamviewer.com/t5/Change-Logs/Linux-v14-5-1691-Full-Change-Log/m-p/69997

Also ensured that QT is wrapped properly to avoid startup issues with
different system-wide QT versions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jagajaga

https://community.teamviewer.com/t5/Change-Logs/Linux-v14-5-1691-Full-Change-Log/m-p/69997

Also ensured that QT is wrapped properly to avoid startup issues with
different system-wide QT versions.
@Ma27 Ma27 mentioned this pull request Aug 22, 2019
10 tasks
@globin globin merged commit cac55a5 into NixOS:master Aug 22, 2019
@Ma27 Ma27 deleted the teamviewer-bump branch August 22, 2019 12:56
};

unpackPhase = ''
ar x $src
tar xf data.tar.*
'';

nativeBuildInputs = [ autoPatchelfHook makeWrapper ];
nativeBuildInputs = [ autoPatchelfHook makeWrapper wrapQtAppsHook ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hook gets added automatically to nativeBuildInputs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants