Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kde: multiple staging fixes #67245

Merged
merged 4 commits into from Aug 22, 2019
Merged

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Aug 22, 2019

Motivation for this change

Some KDE applications are not building currently in the staging-next branch

The patch is coming from here : https://github.com/tsdgeos/grantlee/commits/fix_compilation
I didn't backport the upstream patch because the current master is to far away from the latest tag to apply such big patch cleanly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ttuegel

@ttuegel ttuegel merged commit 84a9120 into NixOS:staging-next Aug 22, 2019
@nyanloutre nyanloutre deleted the fix_kde_update branch August 22, 2019 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants