Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrcpy: 1.8 -> 1.10 #67383

Merged
merged 1 commit into from Aug 24, 2019
Merged

scrcpy: 1.8 -> 1.10 #67383

merged 1 commit into from Aug 24, 2019

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Aug 24, 2019

Motivation for this change

https://github.com/Genymobile/scrcpy/releases/tag/v1.9
https://github.com/Genymobile/scrcpy/releases/tag/v1.10

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @DeltaEvo @lukeadams

@mmahut
Copy link
Member

mmahut commented Aug 24, 2019

Fails on darwin https://github.com/NixOS/nixpkgs/pull/67383/checks?check_run_id=202217794

[33/38] Compiling C object 'app/a172ced@@test_queue@exe/tests_test_queue.c.o'.
FAILED: app/a172ced@@test_queue@exe/tests_test_queue.c.o
/nix/store/4yhnj6g8ixx31jgil477xrir5y3n39im-clang-wrapper-7.1.0/bin/cc -Iapp/a172ced@@test_queue@exe -Iapp -I../app -I../app/src -I/nix/store/gl5yaaflmwpap4sxnbjjck243lpzcpys-ffmpeg-3.4.6-dev/include -I/nix/store/0pn4dchsfz57xi5b3dnwci44krnd53g2-SDL2-2.0.9-dev/include/SDL2 -Xclang -fcolor-diagnostics -pipe -std=c11 -D_THREAD_SAFE -MD -MQ 'app/a172ced@@test_queue@exe/tests_test_queue.c.o' -MF 'app/a172ced@@test_queue@exe/tests_test_queue.c.o.d' -o 'app/a172ced@@test_queue@exe/tests_test_queue.c.o' -c ../app/tests/test_queue.c
../app/tests/test_queue.c:12:5: error: use of undeclared identifier 'NULL'
    queue_init(&queue);
    ^
../app/src/queue.h:16:40: note: expanded from macro 'queue_init'
    (void) ((PQ)->first = (PQ)->last = NULL)
                                       ^
../app/tests/test_queue.c:19:5: error: use of undeclared identifier 'NULL'
    queue_push(&queue, next, &v1);
    ^
../app/src/queue.h:52:29: note: expanded from macro 'queue_push'
        (ITEM)->NEXTFIELD = NULL; \
                            ^
../app/tests/test_queue.c:20:5: error: use of undeclared identifier 'NULL'
    queue_push(&queue, next, &v2);
    ^
../app/src/queue.h:52:29: note: expanded from macro 'queue_push'
        (ITEM)->NEXTFIELD = NULL; \
                            ^
3 errors generated.
ninja: build stopped: subcommand failed.

@mmahut
Copy link
Member

mmahut commented Aug 24, 2019

@GrahamcOfBorg build scrcpy

@mmahut mmahut merged commit d09278c into NixOS:master Aug 24, 2019
@dywedir dywedir deleted the scrcpy branch August 24, 2019 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants