Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yubikey-manager: 2.1.1 -> 3.1.0 #67276

Merged
merged 1 commit into from Sep 3, 2019
Merged

yubikey-manager: 2.1.1 -> 3.1.0 #67276

merged 1 commit into from Sep 3, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Aug 22, 2019

Motivation for this change

https://developers.yubico.com/yubikey-manager/Release_Notes.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Mic92 and benley August 22, 2019 19:09
@mmahut
Copy link
Member

mmahut commented Aug 23, 2019

Fails on darwin with.

smartcard/scard/winscarddll.h:280:13: error: unknown type name 'LPTSTR'
    OUT     LPTSTR mszReaders,
            ^
smartcard/scard/winscarddll.h:286:13: error: unknown type name 'LPTSTR'
    OUT     LPTSTR mszGroups,
            ^
smartcard/scard/winscarddll.h:304:9: error: unknown type name 'LPTSTR'
    OUT LPTSTR szReaderName,
        ^
smartcard/scard/winscarddll.c:529:13: error: unknown type name 'LPTSTR'
    OUT     LPTSTR mszReaders,
            ^
smartcard/scard/winscarddll.c:543:13: error: unknown type name 'LPTSTR'
    OUT     LPTSTR mszGroups,
            ^
smartcard/scard/winscarddll.c:582:9: error: unknown type name 'LPTSTR'
    OUT LPTSTR szReaderName,
        ^
6 errors generated.
error: command 'clang' failed with exit status 1```

@dtzWill
Copy link
Member Author

dtzWill commented Aug 24, 2019

Fails on darwin with.

Those files don't exist in yubikey-manager, but they do in pyscard -- is that where you're seeing the failure?

  1. I should send the update to 1.9.9 (242f916 and follow-up 844420e), maybe that helps?
  2. pyscard patches the path to pcsclite's ".so" library-- does Darwin work without a similar substitution? Just curious :).

@mmahut
Copy link
Member

mmahut commented Aug 25, 2019

@dtzWill yes, it's failing on ofborg as well.

@marsam
Copy link
Contributor

marsam commented Aug 29, 2019

@mmahut pyscard on darwin is fixed by #65163

@mmahut
Copy link
Member

mmahut commented Aug 29, 2019

@GrahamcOfBorg build yubikey-manager

@marsam marsam merged commit 7389bdf into NixOS:master Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

@benley benley benley approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @mmahut @marsam @benley