Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost171: init at 1.71.0 #67282

Merged
merged 3 commits into from Nov 16, 2019
Merged

boost171: init at 1.71.0 #67282

merged 3 commits into from Nov 16, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Aug 22, 2019

Motivation for this change

https://www.boost.org/users/history/version_1_71_0.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

FWIW, using this as my default boost so LGTM :).

@risicle
Copy link
Contributor

risicle commented Aug 23, 2019

nix-review happy macos 10.13

@mmahut mmahut self-assigned this Aug 24, 2019
Co-Authored-By: Jon <jonringer@users.noreply.github.com>
@mmahut
Copy link
Member

mmahut commented Sep 28, 2019

@GrahamcOfBorg build boost17x

@dtzWill dtzWill merged commit 44d9a86 into NixOS:master Nov 16, 2019
@dtzWill dtzWill deleted the feature/boost-1.71 branch November 16, 2019 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants