Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/shell: hardcode coreutils stat #67372

Closed
wants to merge 1 commit into from
Closed

nixos/shell: hardcode coreutils stat #67372

wants to merge 1 commit into from

Conversation

matthewbauer
Copy link
Member

Not all stat implementations support the -c (--printf) argument.
Specifically, busybox stat does not work with it. To avoid conflicts,
just use the absolute path to coreutils.

Fixes #67247

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@matthewbauer
nixos/shell: hardcode coreutils stat
1ff5606 
Not all stat implementations support the -c (--printf) argument.
Specifically, busybox stat does not work with it. To avoid conflicts,
just use the absolute path to coreutils.

Fixes NixOS#67247
tadeokondrak
tadeokondrak reviewed Aug 24, 2019
View reviewed changes
Copy link
Member

@tadeokondrak tadeokondrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this was already fixed by fef4dc5, since busybox does support -c (but not --printf), but this change was made after the 19.03 release.

@matthewbauer
Copy link
Member Author

Thanks! I did not realize that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadeokondrak tadeokondrak tadeokondrak left review comments

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BusyBox v1.30.1 failes to install/update on "nixos-rebuild switch --upgrade"
2 participants
@matthewbauer @tadeokondrak