Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minikube: restore kvm2 plugin #67242

Merged
merged 2 commits into from Aug 22, 2019
Merged

minikube: restore kvm2 plugin #67242

merged 2 commits into from Aug 22, 2019

Conversation

thefloweringash
Copy link
Member

Motivation for this change

Run minikube with kvm2 backend

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ebzzry @copumpkin @vdemeester

@thefloweringash
docker-machine-kvm2: update for changes to minikube
9232a33 
In "minikube: 1.0.1 -> 1.2.0" [1], the package changed from
buildGoPackage to buildGoModule. This package, docker-machine-kvm2, is
built from the same sources and must follow the same packaging.

[1] a12efe9
@thefloweringash
minikube: restore plugins
90776e1 
These were dropped in a12efe9
@vdemeester
Copy link
Member

@GrahamcOfBorg build minikube

@nlewo
Copy link
Member

nlewo commented Aug 22, 2019

Locally tested with kvm2 driver.
LGTM.

vdemeester
vdemeester approved these changes Aug 22, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@kalbasit
Copy link
Member

@GrahamcOfBorg build minikube

@nlewo nlewo merged commit 8d31c94 into NixOS:master Aug 22, 2019
@thefloweringash thefloweringash deleted the minikube-plugins branch August 23, 2019 15:27
@AtkinsChang AtkinsChang mentioned this pull request Dec 3, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@copumpkin copumpkin Awaiting requested review from copumpkin

@kalbasit kalbasit Awaiting requested review from kalbasit

@tadfisher tadfisher Awaiting requested review from tadfisher

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thefloweringash @vdemeester @nlewo @kalbasit