Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

celluloid: 0.16 → 0.17 #67256

Merged
merged 1 commit into from Aug 22, 2019
Merged

celluloid: 0.16 → 0.17 #67256

merged 1 commit into from Aug 22, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Aug 22, 2019

Renamed from gnome-mpv.

https://github.com/celluloid-player/celluloid/releases/tag/v0.17

  • Built on NixOS (sandboxed).
  • Tested playing a video.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM (minor suggestions)
binary works
leaf package

];

buildInputs = [
epoxy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get's rid of a warning, but I still can't see icons.

Suggested change
epoxy
epoxy
hicolor-icon-theme

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the discussion here: #43150 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, interesting, guess i should install some icons then 😄

@jtojnar jtojnar merged commit 0c20b6a into NixOS:master Aug 22, 2019
@jtojnar jtojnar deleted the celluloid-0.17 branch August 22, 2019 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants