Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Store::addToStore taking a string. #3053

Closed
wants to merge 1 commit into from

Conversation

gleber
Copy link
Contributor

@gleber gleber commented Aug 22, 2019

This removes all uses of this function, in most cases wrapping
previously-provided string with a StringSource.

@edolstra There are couple of places where, I am moving data from a StringSink to a Source via StringSource source(sink.s). It is not clear to me if this is the best way. This is my first contribution, so please bear with me. My long-term goal is to investigate the Nix code base enough to look into implementing the intentional store capability.

This removes all uses of this function, in most cases wrapping
previously-provided string with a StringSource.
@zimbatm
Copy link
Member

zimbatm commented Aug 22, 2019

nice! I was touching this code recently and it's nice to see that extra complexity go.

@edolstra
Copy link
Member

I get a test failure in export.sh:

    + nix-store --import
    error: bad archive: input doesn't look like a Nix archive

The reason may be that draining a Source to read a NAR will cause any subsequent data from the same Source to be discarded. This happens with Nix exports and with serialization of NARs in the worker/serve protocol.

@gleber
Copy link
Contributor Author

gleber commented May 30, 2020

Superseded by #3639

@gleber gleber closed this May 30, 2020
@Ericson2314
Copy link
Member

Oh i totally messed this. Bummer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants