Drop Store::addToStore taking a string. #3053
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all uses of this function, in most cases wrapping
previously-provided string with a StringSource.
@edolstra There are couple of places where, I am moving data from a
StringSink
to aSource
viaStringSource source(sink.s)
. It is not clear to me if this is the best way. This is my first contribution, so please bear with me. My long-term goal is to investigate the Nix code base enough to look into implementing the intentional store capability.