Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/pdns-recursor: implement a settings option #67251

Merged
merged 3 commits into from Aug 27, 2019
Merged

nixos/pdns-recursor: implement a settings option #67251

merged 3 commits into from Aug 27, 2019

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Aug 22, 2019 •
edited

Motivation for this change

What @infinisil suggested in PR #58204

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@infinisil what do you suggest for safely deprecating extraConfig?

@rnhmjoj rnhmjoj mentioned this pull request Aug 24, 2019
Merged
7 tasks
infinisil
infinisil requested changes Aug 26, 2019
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat :D

nixos/modules/services/networking/pdns-recursor.nix Show resolved Hide resolved
nixos/modules/services/networking/pdns-recursor.nix Show resolved Hide resolved
@infinisil infinisil merged commit 210756a into NixOS:master Aug 27, 2019
@rnhmjoj rnhmjoj deleted the pdns branch September 14, 2019 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rnhmjoj @infinisil