Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix formatting of aws commands #3052

Closed
wants to merge 1 commit into from
Closed

docs: Fix formatting of aws commands #3052

wants to merge 1 commit into from

Conversation

TheSirC
Copy link

@TheSirC TheSirC commented Aug 22, 2019

Fixing the formatting of the examples 13.1 and 13.2 to send back better formatted commands akin to the one in the sixth point of Example 14.1 (perl = perl;).

Fixing the formatting of the examples 13.1 and 13.2 to send back better formatted commands akin to the one in the sixth point of Example 14.1 (`perl = perl;`).
@grahamc
Copy link
Member

grahamc commented Aug 22, 2019

Hmm... I think <command> is a better choice than <programlisting> but you're right that the display of the command is terrible! I'm going to take a minute to see if there is a simple improvement on the display side before merging this.

@TheSirC
Copy link
Author

TheSirC commented Aug 22, 2019

I thought it was a better match formatting-wise but I do agree that <command> should semantically be the choice here.

@grahamc
Copy link
Member

grahamc commented Aug 22, 2019

I'm not certain this is "enough". What do you think (before & after in the same picture)?

image

This improves other <command>s too:

image

vs:

image

@TheSirC
Copy link
Author

TheSirC commented Aug 22, 2019

Can't see properly because the two last crops hides the commands 😞

Just got it : the font is definitely better if the after is on the top in both.

@grahamc
Copy link
Member

grahamc commented Aug 22, 2019

oh, sorry, hehe the example is the bold nix-serve bit in the center of the two last pictures :)

@TheSirC
Copy link
Author

TheSirC commented Aug 22, 2019

oh, sorry, hehe the example is the bold nix-serve bit in the center of the two last pictures :)

Yeah sorry I just got it, silly me.

@grahamc
Copy link
Member

grahamc commented Aug 22, 2019

I opened a PR to make this nicer: NixOS/nixos-homepage#298

@TheSirC
Copy link
Author

TheSirC commented Aug 22, 2019

Thanks a lot. I am closing this then !

@TheSirC TheSirC closed this Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants