Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtk-vnc: 0.9.0 β†’ 1.0.0 #67255

Merged
merged 1 commit into from Aug 22, 2019
Merged

gtk-vnc: 0.9.0 β†’ 1.0.0 #67255

merged 1 commit into from Aug 22, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Aug 22, 2019

@jtojnar
Copy link
Contributor Author

jtojnar commented Aug 22, 2019

βœ”οΈ Successfully built all dependent packages:

nix-build -A gnome3.gnome-boxes -A gnome3.vinagre -A virt-viewer -A virtmanager

@7c6f434c
Copy link
Member

Why is gvncviewer binary no longer built?

@jtojnar
Copy link
Contributor Author

jtojnar commented Aug 22, 2019

It is built but no longer installed. Since it is just an example it is probably not needed to be installed.

@7c6f434c
Copy link
Member

Wait, what does it lack? Because I used it as a viewer from time to time.

@jtojnar
Copy link
Contributor Author

jtojnar commented Aug 22, 2019

I am not sure what it lacks but it is not a production-ready application – it is an example of how to use the library. So it makes sense that during the build system port, they stopped installing it.

@mmahut
Copy link
Member

mmahut commented Aug 22, 2019

That's fair, if they do to maintain it and there is an alternative we should probably not ship it as a binary.

@mmahut mmahut merged commit 4bfb26b into NixOS:master Aug 22, 2019
nativeBuildInputs = [
python3 pkgconfig intltool libtool gobject-introspection vala
patches = [
(fetchpatch {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment about the undeclared thing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, I always ask other people for that but keep forgetting it myself πŸ˜›

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🀣 The tables have turned

];

configureFlags = [
"--with-examples"
buildInputs = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libgcrypt
cyrus_sasl
libpulseaudio
gtk3
];

passthru = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pname for packageName?

@worldofpeace worldofpeace mentioned this pull request Aug 22, 2019
10 tasks
@jtojnar jtojnar deleted the gtk-vnc-1.0 branch August 22, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants