Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moc: disable curl support #67381

Closed
wants to merge 1 commit into from
Closed

moc: disable curl support #67381

wants to merge 1 commit into from

Conversation

eugenezastrogin
Copy link
Member

@eugenezastrogin eugenezastrogin commented Aug 24, 2019

Motivation for this change

Recent moc package refactor enabled pretty much all compilation flags by default.
While moc itself works fine, it no longer exits gracefully. With both ffmpeg and curl support compiled in, player segfaults on exit. While this issue is being investigated upstream, I propose to disable curl support by default, since having it is less crucial then graceful closing of player for majority of users.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@eugenezastrogin
Copy link
Member Author

For some funny reason this PR a day ago solved this few month old issue. Closing...

@eugenezastrogin eugenezastrogin deleted the fix/moc-2.5.2 branch August 24, 2019 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant