Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.moderngl_window: init at 1.2.0 #67399

Merged
merged 2 commits into from Nov 4, 2019
Merged

pythonPackages.moderngl_window: init at 1.2.0 #67399

merged 2 commits into from Nov 4, 2019

Conversation

c0deaddict
Copy link
Member

Motivation for this change

Examples of pythonPackages.moderngl use this package. When upgrading the package wanted to run the tests.

This PR also upgrades pythonPackages.pyglet to 1.4.2 because moderngl_window requires it.

Tested this package (and the changes to pyglet) indirectly with examples of ModernGL.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@c0deaddict c0deaddict requested a review from FRidh as a code owner August 24, 2019 15:59
@c0deaddict c0deaddict mentioned this pull request Aug 24, 2019
Merged
10 tasks
@mmahut
Copy link
Member

mmahut commented Aug 25, 2019

@GrahamcOfBorg build python37Packages.moderngl_window

@c0deaddict c0deaddict force-pushed the feature/init-python3-moderngl-window branch 2 times, most recently from a6153f2 to a6a1ba1 Compare August 25, 2019 14:05
@mmahut
Copy link
Member

mmahut commented Aug 25, 2019

@GrahamcOfBorg build pythonPackages.moderngl_window python3Packages.moderngl_window

@c0deaddict
Copy link
Member Author

@mmahut can this PR be merged?

@mmahut
Copy link
Member

mmahut commented Oct 31, 2019

Sorry for late reply - please, do you mind splitting the package upgrade and the new package into two separate commits?

@mmahut mmahut self-assigned this Oct 31, 2019
@c0deaddict c0deaddict force-pushed the feature/init-python3-moderngl-window branch from a6a1ba1 to 2db6316 Compare November 2, 2019 13:12
@c0deaddict
Copy link
Member Author

No problem, i've split them up.

@jonringer
Copy link
Contributor

do you mind rebasing on top of master? there's been a lot of changes to python-modules since then

git pull -r orgin master
git push <fork> <branch> --force

@c0deaddict c0deaddict force-pushed the feature/init-python3-moderngl-window branch from 2db6316 to 83a0319 Compare November 3, 2019 15:21
@c0deaddict
Copy link
Member Author

Done, rebased it on top of master.

jonringer
jonringer approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS (failures are related to other packages)
diff LGTM

[26 built (7 failed), 44 copied (927.0 MiB), 533.4 MiB DL]
error: build of '/nix/store/y3m0m0jwwx9nlm5321ay4cs96ykdrhbx-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/67399
4 package failed to build:
python27Packages.baselines python37Packages.baselines python37Packages.rl-coach python38Packages.baselines

14 package were build:
printrun python27Packages.gym python27Packages.pyglet python27Packages.pytmx python37Packages.gym python37Packages.moderngl-window python37Packages.pyglet python37Packages.pytmx python37Packages.roboschool python38Packages.gym python38Packages.moderngl-window python38Packages.pyglet python38Packages.pytmx python38Packages.roboschool

@jonringer
Copy link
Contributor

@ofborg build printrun python27Packages.gym python27Packages.pyglet python27Packages.pytmx python37Packages.gym python37Packages.moderngl-window python37Packages.pyglet python37Packages.pytmx python37Packages.roboschool python38Packages.gym python38Packages.moderngl-window python38Packages.pyglet python38Packages.pytmx python38Packages.roboschool

@jonringer jonringer merged commit 018f66f into NixOS:master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut left review comments

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees

@mmahut mmahut

Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c0deaddict @mmahut @jonringer