Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate the min and max radius from the game #2298

Merged
merged 10 commits into from
Aug 24, 2019

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Aug 24, 2019

And use the min radius for collision detection. This addresses the collision issues in #2237.

@@ -68,9 +68,6 @@ using ::std::placeholders::_3;
constexpr Length pre_ἐρατοσθένης_default_ephemeris_fitting_tolerance =
1 * Milli(Metre);
constexpr Time max_time_between_checkpoints = 180 * Day;
// Below this threshold detect a collision to prevent the integrator and the
// downsampling from going postal.
constexpr double mean_radius_tolerance = 0.9;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep a tolerance so that falling a little too fast doesn't cause Princpia to vaporize the spacecraft; 0.99 should be good enough (if you are going fast enough that your centre of mass would be 1 % of the way to the centre of the body after one frame, survival is unlikely).

Sorry, something went wrong.

@eggrobin eggrobin added the LGTM label Aug 24, 2019
@pleroy pleroy merged commit 389f1fe into mockingbirdnest:master Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants