Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unifiStable: 5.10.26 -> 5.11.39 #67335

Merged
merged 1 commit into from Aug 23, 2019
Merged

unifiStable: 5.10.26 -> 5.11.39 #67335

merged 1 commit into from Aug 23, 2019

Conversation

cw789
Copy link
Contributor

@cw789 cw789 commented Aug 23, 2019 •
edited

Motivation for this change

Release Notes

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @erictapen @mmahut

@ofborg ofborg bot requested a review from globin August 23, 2019 11:20
@erictapen
Copy link
Member

Hey @cw789, thanks again for the update. Would you be interested in taking maintainership for the package? I'm not really behind the latest updates atm…

@GrahamcOfBorg build unifiStable

@mmahut mmahut merged commit 3847e4d into NixOS:master Aug 23, 2019
@cw789
Copy link
Contributor Author

cw789 commented Aug 29, 2019

@erictapen: Hi Justin. I'm sorry, my interest isn't that high to take maintainership for this package at the moment.
I'm just a user of it and not very passionate about UniFi.

I think it would be best if UniFi itself could also contribute & maintain, as it is there child.
Calling people working at UniFi, if someone could bring this to there table:
@ubnt-jeff-hansen @StalkerRus @caquino @cbuechler @UBNT-Petr @ubnt-chuck @JoshuaEllisUbnt

Sorry if I mentioned someone not related to UniFi.

@benpye
Copy link
Contributor

benpye commented Sep 6, 2019

Would this be suitable for a backport?

@erictapen
Copy link
Member

Did this update address a security issue? If not I'd say no.

@cw789 cw789 deleted the unifi_update branch October 3, 2019 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cw789 @erictapen @benpye @mmahut