Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.itypes: init at 1.1.0 #67319

Closed
wants to merge 2 commits into from

Conversation

ldelelis
Copy link
Member

Motivation for this change

I'm enjoying my experience as a developer with NixOS so far, and I want to make nixpkgs friendlier to other Python developers. itypes is a dependency to many projects I currently work at.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ldelelis ldelelis requested a review from FRidh as a code owner August 23, 2019 02:40
@ldelelis ldelelis changed the title Python itypes python.pkgs.itypes: init at 1.1.0 Aug 23, 2019
@ldelelis ldelelis changed the title python.pkgs.itypes: init at 1.1.0 pythonPackages.itypes: init at 1.1.0 Aug 23, 2019
@risicle
Copy link
Contributor

risicle commented Aug 23, 2019

#66391 includes an itypes 1.1.0 package, which seems to work well - I'd throw your weight at helping get that PR merged.

@ldelelis
Copy link
Member Author

@risicle That's fair, I'll get on that and close this PR.

@ldelelis ldelelis closed this Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants