Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cm256cc: init at 1.0.5 #67403

Merged
merged 1 commit into from Aug 24, 2019
Merged

cm256cc: init at 1.0.5 #67403

merged 1 commit into from Aug 24, 2019

Conversation

alkeryn
Copy link
Contributor

@alkeryn alkeryn commented Aug 24, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

@markuskowa this one is one of the deps of sdrangel, i'm doing them in separate PR ^

Copy link
Member

@markuskowa markuskowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jus minor formatting to increase readability.

pkgs/development/libraries/cm256cc/default.nix Outdated Show resolved Hide resolved
@markuskowa
Copy link
Member

markuskowa commented Aug 24, 2019

@GrahamcOfBorg build cm256cc

@alkeryn alkeryn force-pushed the cm256cc branch 2 times, most recently from b19598b to 226fd7f Compare August 24, 2019 18:44
@alkeryn
Copy link
Contributor Author

alkeryn commented Aug 24, 2019

Also a quesition, in the rev should i put a tag number rather than the hash of lattest commit ?
just thought about it now ^

@alkeryn alkeryn force-pushed the cm256cc branch 2 times, most recently from 710e433 to 8f5f8ed Compare August 24, 2019 19:33
@alkeryn alkeryn changed the title init: cm256cc 1.0.5 cm256cc: init at 1.0.5 Aug 24, 2019
@markuskowa
Copy link
Member

Also a quesition, in the rev should i put a tag number rather than the hash of lattest commit ?

Yes, a tag is the preferred choice.

@alkeryn
Copy link
Contributor Author

alkeryn commented Aug 24, 2019

Also a quesition, in the rev should i put a tag number rather than the hash of lattest commit ?

Yes, a tag is the preferred choice.

Ok i'll just patch it and do the same for serialdv ^

@markuskowa markuskowa merged commit 12bf3d2 into NixOS:master Aug 24, 2019
@alkeryn alkeryn deleted the cm256cc branch August 24, 2019 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants