Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uq: init at 2018-05-27 #67380

Merged
merged 1 commit into from Aug 30, 2019
Merged

uq: init at 2018-05-27 #67380

merged 1 commit into from Aug 30, 2019

Conversation

doronbehar
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

aanderse
aanderse requested changes Aug 24, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a few minor nitpicks. Thanks for contributing this.

pkgs/misc/uq/default.nix Outdated Show resolved Hide resolved
pkgs/misc/uq/default.nix Outdated Show resolved Hide resolved
pkgs/misc/uq/default.nix Outdated Show resolved Hide resolved
pkgs/misc/uq/default.nix Outdated Show resolved Hide resolved
doronbehar
doronbehar commented Aug 24, 2019
View reviewed changes
Copy link
Contributor Author

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review. I think I've fixed everything.

@mmahut
Copy link
Member

mmahut commented Aug 25, 2019

@doronbehar I think you forgot to force push your changes.

@doronbehar
Copy link
Contributor Author

You were right @mmahut, thanks for catching that. I hadn't had the chance to push the changes till now so I hope this will get some attention never the less. @aanderse you don't have by any chance write privilidges to this repo right?

@aanderse
Copy link
Member

@doronbehar your changes look good 👍 Squash your commits into a single uq: init at 2018-05-27 commit and I'm happy to merge. Thanks!

aanderse
aanderse reviewed Aug 30, 2019
View reviewed changes
pkgs/misc/uq/default.nix Outdated Show resolved Hide resolved
@doronbehar
Copy link
Contributor Author

@aanderse did you catch my force push?

@aanderse
Copy link
Member

aanderse commented Aug 30, 2019 •
edited

@GrahamcOfBorg build uq

@aanderse
Copy link
Member

@doronbehar oops! Need to add to the package list!

@doronbehar
Copy link
Contributor Author

I wonder how that got missed. Now @ofborg should build it.

@aanderse aanderse merged commit 7655962 into NixOS:master Aug 30, 2019
@aanderse
Copy link
Member

Thanks @doronbehar 🎉

@doronbehar
Copy link
Contributor Author

Thank you! 🍻

@doronbehar doronbehar deleted the package-uq branch March 2, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doronbehar @mmahut @aanderse