Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ljsyscall: init at 20180515 #67385

Merged
merged 1 commit into from Aug 28, 2019
Merged

ljsyscall: init at 20180515 #67385

merged 1 commit into from Aug 28, 2019

Conversation

lblasc
Copy link
Contributor

@lblasc lblasc commented Aug 24, 2019

Motivation for this change

Add LuaJIT syscall library, sadly latest release is unusable.
It is possible to use this library with plain Lua 5.1 with help of luaffi.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @teto

disassembler
disassembler suggested changes Aug 24, 2019
View reviewed changes
pkgs/development/lua-modules/overrides.nix Outdated Show resolved Hide resolved
pkgs/development/lua-modules/overrides.nix Outdated Show resolved Hide resolved
@lblasc
Copy link
Contributor Author

lblasc commented Aug 24, 2019

@disassembler thx for looking into it. Applied changes you requested.

@lblasc
Copy link
Contributor Author

lblasc commented Aug 26, 2019

Also enabled ljsyscall on Lua 5.2, it works fine with luaffi.

cc @disassembler @teto

@teto teto merged commit 4d11f5d into NixOS:master Aug 28, 2019
@lblasc lblasc deleted the ljsyscall branch August 28, 2019 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disassembler disassembler disassembler requested changes

Assignees
No one assigned
Labels
6.topic: lua 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lblasc @disassembler @teto