Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xmind: fix mimeType, xscheme-handler -> x-scheme-handler #67288

Merged
merged 1 commit into from Aug 22, 2019
Merged

xmind: fix mimeType, xscheme-handler -> x-scheme-handler #67288

merged 1 commit into from Aug 22, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Aug 22, 2019

Motivation for this change

Something has been printing a warning about this,
not sure what but it's an easy fix :).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Ma27 Ma27 self-requested a review August 22, 2019 19:13
@matthewbauer
Copy link
Member

Most likely update-mime-database? Maybe we should have some NixOS tests that can tell us about these errors. update-desktop-database

@Ma27
Copy link
Member

Ma27 commented Aug 22, 2019

Not sure. Being honestly I guess that I simply mistyped this while adding the desktop file to the derivation. AUR also uses x-scheme-handler (https://aur.archlinux.org/cgit/aur.git/tree/xmind.desktop?h=xmind) and the package didn't change there for about a year: https://aur.archlinux.org/cgit/aur.git/commit/?h=xmind

@Ma27
Copy link
Member

Ma27 commented Aug 22, 2019

Merging now. I'm pretty sure that this is a bug in the package (sorry for that!).

Even if we implement tests for MIME databases, this should be done in a different PR.

@Ma27 Ma27 merged commit b51004a into NixOS:master Aug 22, 2019
@Ma27
Copy link
Member

Ma27 commented Aug 22, 2019

@dtzWill thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
0.kind: bug 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @matthewbauer @Ma27