Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitea: 1.9.1 -> 1.9.2 #67292

Merged
merged 1 commit into from Aug 28, 2019
Merged

Conversation

kolaente
Copy link
Member

@kolaente kolaente commented Aug 22, 2019

Motivation for this change

Follow-up from #67269

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@kolaente kolaente mentioned this pull request Aug 22, 2019
10 tasks
@etu
Copy link
Contributor

etu commented Aug 22, 2019

@kolaente It would be great if you could cherry-pick with -x to get the reference to the original commit.

@etu
Copy link
Contributor

etu commented Aug 22, 2019

@GrahamcOfBorg build nixosTests.gitea

Regardless of the cherry picking flag we can change the actual changes in the meanwhile.

@kolaente
Copy link
Member Author

@etu, done.

@etu
Copy link
Contributor

etu commented Aug 23, 2019

@kolaente We usually do a cherry pick of the commit implementing the change rather than the merge commit.

That would be git cherry-pick -x 3ddb1a09fc7c8ba6472814d18822eb3c7604a778 -- that commit 3ddb1a0 is your original change.

@mmahut
Copy link
Member

mmahut commented Aug 24, 2019

@GrahamcOfBorg test gitea

(cherry picked from commit 3ddb1a0)
@kolaente
Copy link
Member Author

kolaente commented Aug 27, 2019

@etu Done. I didn't know that, thanks for clarifying. Still new to nix and how things are done here 😅

@mmahut
Copy link
Member

mmahut commented Aug 27, 2019

@GrahamcOfBorg test gitea

@etu etu merged commit 51e1e3c into NixOS:release-19.03 Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants