Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dlib: 19.16 -> 19.17 #67290

Merged
merged 1 commit into from Aug 25, 2019
Merged

dlib: 19.16 -> 19.17 #67290

merged 1 commit into from Aug 25, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Aug 22, 2019 •
edited

Motivation for this change

https://github.com/davisking/dlib/releases/tag/v19.17

Also had to change the expression for setup.py flags as 19.17 doesn't
support --yes anymore.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Ma27
dlib: 19.16 -> 19.17
311516f 
https://github.com/davisking/dlib/releases/tag/v19.17

Also had to change the expression for setup.py flags as 19.17 doesn't
support `--yes` anymore.
@Ma27 Ma27 requested a review from FRidh as a code owner August 22, 2019 19:12
@mmahut
Copy link
Member

mmahut commented Aug 24, 2019

@GrahamcOfBorg build python27Packages.dlib python27Packages.face_recognition python37Packages.dlib python37Packages.face_recognition

@mmahut mmahut merged commit 7bdda40 into NixOS:master Aug 25, 2019
@Ma27 Ma27 deleted the bump-dlib branch August 25, 2019 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ma27 @mmahut