Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system-syzygy: init at 1.0.1 #67353

Merged
merged 1 commit into from Sep 28, 2019
Merged

system-syzygy: init at 1.0.1 #67353

merged 1 commit into from Sep 28, 2019

Conversation

marius851000
Copy link
Contributor

Motivation for this change

Wanted to add this game.

Things done

Not sure this will work on macos, but the game is compatible. I don't have a macOS device to test this.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@marius851000
Copy link
Contributor Author

@mmahut I've also corrected the problem here.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/55

alexarice
alexarice reviewed Sep 13, 2019
View reviewed changes
pkgs/games/system-syzygy/default.nix Outdated Show resolved Hide resolved
pkgs/games/system-syzygy/default.nix Outdated Show resolved Hide resolved
@alexarice
Copy link
Contributor

did you intend to close this?

@marius851000
Copy link
Contributor Author

No, sorry. Don't know why it closed (should be due to the fact I mistakinfly force-pushed while my commit wasn't in git)

@marius851000 marius851000 reopened this Sep 16, 2019
alexarice
alexarice approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs with nix-review

@marius851000 marius851000 deleted the syzygy branch September 17, 2019 10:16
@marius851000 marius851000 restored the syzygy branch September 17, 2019 10:17
@marius851000
Copy link
Contributor Author

Still don't know why I closed this ... (maybe the same problem)

@marius851000 marius851000 reopened this Sep 17, 2019
@Lassulus
Copy link
Member

tested with nix-review, played a little bit, but gave up after a while

@Lassulus Lassulus merged commit afbb73e into NixOS:master Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut left review comments

@alexarice alexarice alexarice approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marius851000 @nixos-discourse @alexarice @Lassulus @mmahut