Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irccloud: init at 0.13.0 #67334

Merged
merged 2 commits into from Aug 24, 2019
Merged

irccloud: init at 0.13.0 #67334

merged 2 commits into from Aug 24, 2019

Conversation

lightbulbjim
Copy link
Contributor

Motivation for this change

Adding the IRCCloud desktop client.

It's an Electron app, so the source build is pretty messy with a lot of Node deps downloaded at build time. Consequently it won't build in sandbox mode.

Fortunately an official AppImage is provided (and is the preferred version as far as I can tell) so I'm using that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

AppImage is used as the source build is unpure (Yarn pulls in a lot of Node
dependencies over the network).
@mmahut
Copy link
Member

mmahut commented Aug 23, 2019

@GrahamcOfBorg build irccloud

@disassembler disassembler merged commit 3ad7a6a into NixOS:master Aug 24, 2019
@lightbulbjim lightbulbjim deleted the irccloud branch August 24, 2019 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants