Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel-buildtools: 0.22.0 -> 0.28.0 #65277

Merged
merged 1 commit into from Jul 24, 2019
Merged

bazel-buildtools: 0.22.0 -> 0.28.0 #65277

merged 1 commit into from Jul 24, 2019

Conversation

u-quark
Copy link
Contributor

@u-quark u-quark commented Jul 22, 2019 •
edited

Motivation for this change

Continuation from #64537

Update to the latest upstream version release: 0.28.0.

I've updated the dependencies by using go2nix. The latest version of go2nix changed a bit the derivation (adding fetchhg, fetchbzr, fetchsvn even if they are not used).

cc @Profpatsch @uri-canva

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@u-quark u-quark requested a review from Profpatsch as a code owner July 22, 2019 18:12
@u-quark u-quark mentioned this pull request Jul 22, 2019
Closed
10 tasks
Profpatsch
Profpatsch reviewed Jul 23, 2019
View reviewed changes
pkgs/development/tools/build-managers/bazel/buildtools/default.nix
src = fetchgit {
inherit rev;
url = "https://github.com/bazelbuild/buildtools";
sha256 = "1d8zjgbg77sk27cz9pjz1h6ajwxqmvdzqgwa2jbh6iykibhpadq0";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to replace fetchFromGitHub here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Profpatsch I am trying to keep as much of the derivation returned from go2nix.

@Profpatsch
Copy link
Member

@GrahamcOfBorg build bazel-buildtools

@Profpatsch
Copy link
Member

CI is failing

@u-quark
Copy link
Contributor Author

u-quark commented Jul 23, 2019

I will play around and see I can make CI succeed.

@u-quark u-quark force-pushed the bazel-buildtools-bump-0.28.0 branch from a1310f2 to 52aaed3 Compare July 23, 2019 13:52
@u-quark
Copy link
Contributor Author

u-quark commented Jul 23, 2019

@Profpatsch Is CI working now? I added back the github.com/google/skylark as a dependency, that was what was failing before. Not sure why go2nix did not pick this up. This is the latest version of that library (it has been renamed to https://github.com/google/starlark-go but the code still references github.com/google/skylark).

@Profpatsch
Copy link
Member

@GrahamcOfBorg build bazel-buildtools

@Profpatsch Profpatsch merged commit 6d25177 into NixOS:master Jul 24, 2019
@u-quark
Copy link
Contributor Author

u-quark commented Jul 25, 2019

Thanks @Profpatsch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Profpatsch Profpatsch Profpatsch left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@u-quark @Profpatsch