Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kdeconnect: Fix build #65228

Merged
merged 1 commit into from Jul 22, 2019
Merged

kdeconnect: Fix build #65228

merged 1 commit into from Jul 22, 2019

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Jul 21, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@JohnAZoidberg JohnAZoidberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It builds now, but how is this binary used?
Nix won't include it in the path there. Does KDE maybe directly look for it at that path?

@bkchr
Copy link
Contributor Author

bkchr commented Jul 21, 2019

@JohnAZoidberg it still works. I assume that the last QT update maybe changed some CMake paths, but as the scripts use these paths internally everything seems to be fine.

@adisbladis
Copy link
Member

Note to self: This will break the home manager module and we'll need an additional check there.

@FRidh FRidh merged commit bc4361a into NixOS:master Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants