Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teamspeak_server: add missing libstdc++ #65224

Merged
merged 2 commits into from Jul 21, 2019
Merged

teamspeak_server: add missing libstdc++ #65224

merged 2 commits into from Jul 21, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jul 21, 2019 •
edited

Also convert to autoPatchelfHook.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
teamspeak_server: add missing libstdc++
e423045 
Also convert to autoPatchelfHook.
@Mic92
Copy link
Member Author

Mic92 commented Jul 21, 2019

Since the current package is obviously broken I would rather merge this sooner then later.

@Mic92 Mic92 merged commit 104f8a0 into NixOS:master Jul 21, 2019
@Mic92 Mic92 mentioned this pull request Jul 21, 2019
Closed
10 tasks
@Mic92 Mic92 deleted the teamspeak branch July 21, 2019 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Mic92