Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blockbook: increase ulimit -n on darwin for packr execution #65115

Merged
merged 1 commit into from Jul 27, 2019
Merged

blockbook: increase ulimit -n on darwin for packr execution #65115

merged 1 commit into from Jul 27, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Jul 20, 2019

Motivation for this change

When testing #64987, blockbook's build would fail for me on macos 10.13 due to too many open files during the packr process. Bumping the ulimit -n fixes that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
blockbook: increase ulimit -n on darwin for packr execution
f60b221 
macos default can cause build failures due to too many open files
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 labels Jul 20, 2019
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build blockbook

@worldofpeace worldofpeace merged commit f9b3cf8 into NixOS:master Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @worldofpeace