Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpPackages.mailparse: 3.0.2 -> 3.0.3 #65232

Merged
merged 1 commit into from Jul 22, 2019
Merged

phpPackages.mailparse: 3.0.2 -> 3.0.3 #65232

merged 1 commit into from Jul 22, 2019

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Jul 21, 2019 •
edited

Motivation for this change

Mailparse was not yet compatible with PHP 7.3, but version 3.0.3 is.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@caugner
phpPackages.mailparse: 3.0.2 -> 3.0.3
2c55fe1 
Mailparse 3.0.3 adds PHP 7.3 compatibility.
@caugner caugner changed the title WIP: phpPackages.mailparse: 3.0.2 -> 3.0.3 phpPackages.mailparse: 3.0.2 -> 3.0.3 Jul 21, 2019
@aanderse
Copy link
Member

@GrahamcOfBorg build php71Packages.mailparse php72Packages.mailparse php73Packages.mailparse

@etu etu merged commit 8866b70 into NixOS:master Jul 22, 2019
@caugner caugner deleted the patch-1 branch July 22, 2019 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@caugner @aanderse @etu